domverse/photoanalyzer
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

US03-04 — Review and Approve Proposals in the Browser #18

New Issue
Closed
opened 2026-07-13 13:10:43 +02:00 by domverse · 3 comments
domverse commented 2026-07-13 13:10:43 +02:00
Owner
Copy Link

Source specification: delivery_backlog/stories/US03-04-proposal-ui.md

US03-04 — Review and Approve Proposals in the Browser

Epic: E03

As a user, I want to inspect evidence, edit a proposal, and approve it so I retain
control over album naming.

Acceptance criteria

  • The view shows source album, suggested name, evidence summary, rationale, confidence,
    validation issues, and affected count.
  • Edits validate promptly; collisions and invalid names are actionable.
  • Approval requires explicit action and rejects stale state visibly.
  • Reload preserves edits and approval state through the API.

Automated tests

  • UI tests cover editing, errors, collision guidance, approval, stale conflict, and
    keyboard operation.
  • Playwright asserts no file path changes occur during proposal approval.

Dependencies

  • US03-03
Source specification: [delivery_backlog/stories/US03-04-proposal-ui.md](https://git.domverse-berlin.eu/domverse/photoanalyzer/src/branch/main/delivery_backlog/stories/US03-04-proposal-ui.md) # US03-04 — Review and Approve Proposals in the Browser Epic: [E03](https://git.domverse-berlin.eu/domverse/photoanalyzer/src/branch/main/delivery_backlog/E03-album-proposals.md) As a user, I want to inspect evidence, edit a proposal, and approve it so I retain control over album naming. ## Acceptance criteria - The view shows source album, suggested name, evidence summary, rationale, confidence, validation issues, and affected count. - Edits validate promptly; collisions and invalid names are actionable. - Approval requires explicit action and rejects stale state visibly. - Reload preserves edits and approval state through the API. ## Automated tests - UI tests cover editing, errors, collision guidance, approval, stale conflict, and keyboard operation. - Playwright asserts no file path changes occur during proposal approval. ## Dependencies - US03-03
domverse added this to the E03 — Album Proposals milestone 2026-07-13 13:10:43 +02:00
domverse added the area/frontendtype/featurepriority/normal labels 2026-07-13 13:10:43 +02:00
domverse added a new dependency 2026-07-13 13:11:22 +02:00
#17 US03-03 — Generate and Persist Versioned Proposals
domverse added a new dependency 2026-07-13 13:11:23 +02:00
#19 US03-05 — Automate Phase C End-to-End Acceptance
domverse added this to the Photo Analyzer Delivery project 2026-07-13 13:19:45 +02:00
domverse added the status/backlog label 2026-07-13 13:52:49 +02:00
domverse added status/in-progress and removed status/backlog labels 2026-08-15 13:58:26 +02:00
domverse self-assigned this 2026-08-15 13:58:26 +02:00
domverse commented 2026-08-15 13:58:27 +02:00
Author
Owner
Copy Link

Claimed for implementation on branch us/US03-04-review-and-approve-proposals-in-the-browser.

Claimed for implementation on branch `us/US03-04-review-and-approve-proposals-in-the-browser`.
domverse added status/review and removed status/in-progress labels 2026-08-15 14:07:44 +02:00
domverse commented 2026-08-15 14:07:44 +02:00
Author
Owner
Copy Link

Submitted for review: #64

Tests passed:

  • work_item/scripts/python -m unittest discover -s work_item/tests -v
  • work_item/scripts/python -m pytest tests -q
  • work_item/scripts/python -m pytest tests/e2e/test_albums_ui.py -q
Submitted for review: https://git.domverse-berlin.eu/domverse/photoanalyzer/pulls/64 Tests passed: - `work_item/scripts/python -m unittest discover -s work_item/tests -v` - `work_item/scripts/python -m pytest tests -q` - `work_item/scripts/python -m pytest tests/e2e/test_albums_ui.py -q`
domverse added status/done and removed status/review labels 2026-08-15 14:07:50 +02:00
domverse commented 2026-08-15 14:07:51 +02:00
Author
Owner
Copy Link

Completed and merged via PR #64.

Completed and merged via PR #64.
domverse moved this to Done in Photo Analyzer Delivery on 2026-08-16 11:58:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/backend
Backend services, jobs, or API
 area/database
Schema, persistence, migration, or queries
 area/filesystem
Filesystem identity, mutation, or storage
 area/frontend
Browser UI and client-side application
 area/integration
External tools or provider integrations
 area/testing
Automated test suites, fixtures, and tooling
 priority/critical
Release-blocking safety or correctness
 priority/high
Important phase outcome
 priority/normal
Normal planned work
 status/backlog
Awaiting dependency eligibility or prioritization
 status/blocked
Cannot proceed without an explicit resolution
 status/done
Merged, tested, and completed
 status/in-progress
Currently being implemented
 status/ready
Eligible to be claimed
 status/review
Submitted in a pull request for review
 type/feature
User-facing or domain capability
 type/hardening
Security, resilience, operations, or release hardening
 type/migration
Donor extraction, migration, or legacy consolidation
 type/test
Automated test infrastructure or acceptance coverage
No Label area/frontend priority/normal status/done type/feature
Milestone
No items
No Milestone E03 — Album Proposals
Projects
Clear projects
No project Photo Analyzer Delivery
Assignees
Clear assignees
domverse
No Assignees domverse
1 Participants
Notifications
Due Date
No due date set.
Blocks
#19 US03-05 — Automate Phase C End-to-End Acceptance
domverse/photoanalyzer
Depends on
#17 US03-03 — Generate and Persist Versioned Proposals
domverse/photoanalyzer
Reference: domverse/photoanalyzer#18
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?