domverse/photoanalyzer
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

US04-03: Apply and Verify Guarded Renames #68

Merged
domverse merged 1 commits from us/US04-03-apply-and-verify-guarded-renames into main 2026-08-16 11:27:09 +02:00
Conversation 1 Commits 1 Files Changed 7 +1222
domverse commented 2026-08-16 11:26:10 +02:00
Owner
Copy Link

Implements #22

Tests:

  • work_item/scripts/python -m unittest discover -s work_item/tests -v
  • work_item/scripts/python -m pytest tests -q
  • work_item/scripts/python -m pytest tests/integration/test_rename_apply.py tests/integration/test_rename_recovery.py -q

Commit: 47350132784b332c816c857bf2e7e30da793ff65

Implements #22 Tests: - `work_item/scripts/python -m unittest discover -s work_item/tests -v` - `work_item/scripts/python -m pytest tests -q` - `work_item/scripts/python -m pytest tests/integration/test_rename_apply.py tests/integration/test_rename_recovery.py -q` Commit: `47350132784b332c816c857bf2e7e30da793ff65`
domverse added 1 commit 2026-08-16 11:26:11 +02:00
US04-03: Apply and Verify Guarded Renames 4735013278
domverse commented 2026-08-16 11:26:43 +02:00
Author
Owner
Copy Link

This PR delivers both US04-03 (#22) and US04-04 (#23) as one change, per the agreed Phase D grouping: apply and recovery are two halves of one crash-safe transaction — recovery reads exactly the journal evidence apply writes, so splitting them would ship a filesystem-mutating apply with no recovery.

Covered here:

  • US04-03: version/checksum-confirmed apply, exclusive mutation lease, preconditions rechecked immediately before each mutation, staged case-only and copy-verify-delete cross-filesystem procedures, postcondition byte/path verification, stable-ID reconciliation and path history.
  • US04-04: evidence-based recovery classification, resume, rollback with hash revalidation, manual-recovery blocking, and idempotency across repeated restarts. Fault injection kills a real child process at every persisted journal transition.

Tests: tests/integration/test_rename_apply.py (13) and tests/integration/test_rename_recovery.py (15). Full suite 383 passing.

This PR delivers **both** US04-03 (#22) and US04-04 (#23) as one change, per the agreed Phase D grouping: apply and recovery are two halves of one crash-safe transaction — recovery reads exactly the journal evidence apply writes, so splitting them would ship a filesystem-mutating apply with no recovery. Covered here: - US04-03: version/checksum-confirmed apply, exclusive mutation lease, preconditions rechecked immediately before each mutation, staged case-only and copy-verify-delete cross-filesystem procedures, postcondition byte/path verification, stable-ID reconciliation and path history. - US04-04: evidence-based recovery classification, resume, rollback with hash revalidation, manual-recovery blocking, and idempotency across repeated restarts. Fault injection kills a real child process at every persisted journal transition. Tests: tests/integration/test_rename_apply.py (13) and tests/integration/test_rename_recovery.py (15). Full suite 383 passing.
domverse merged commit 7103cb84bf into main 2026-08-16 11:27:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/backend
Backend services, jobs, or API
 area/database
Schema, persistence, migration, or queries
 area/filesystem
Filesystem identity, mutation, or storage
 area/frontend
Browser UI and client-side application
 area/integration
External tools or provider integrations
 area/testing
Automated test suites, fixtures, and tooling
 priority/critical
Release-blocking safety or correctness
 priority/high
Important phase outcome
 priority/normal
Normal planned work
 status/backlog
Awaiting dependency eligibility or prioritization
 status/blocked
Cannot proceed without an explicit resolution
 status/done
Merged, tested, and completed
 status/in-progress
Currently being implemented
 status/ready
Eligible to be claimed
 status/review
Submitted in a pull request for review
 type/feature
User-facing or domain capability
 type/hardening
Security, resilience, operations, or release hardening
 type/migration
Donor extraction, migration, or legacy consolidation
 type/test
Automated test infrastructure or acceptance coverage
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
domverse
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: domverse/photoanalyzer#68
Delete Branch "us/US04-03-apply-and-verify-guarded-renames"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?